Do not use hadd_pd to implement reduce_add#1108
Merged
serge-sans-paille merged 3 commits intomasterfrom Apr 18, 2025
Merged
Conversation
It's generally slower than the sse2 version due to a latency of 5 (!) for hadd_pd. Related to #1107
serge-sans-paille
force-pushed
the
feature/faster-reduce_add
branch
from
6d0c663 to
634b18f
Compare
Forwarding to sse is actually faster. Related to #1107
serge-sans-paille
force-pushed
the
feature/faster-reduce_add
branch
from
a208210 to
b0a4665
Compare
Contributor
Author
|
@DiamonDinoia : why did you guarded the code here: 174c475#diff-c4f5d7f47f45c737cc1723af31069217834daf7da679a0b4ff255a4a6ae73c83R1413 this "intrinsic" seems to be standard - and it passes our validation without the guard. |
Contributor
|
I see, I thought it was an icc only intrinsic from the way it was used in Agner's vcl. Altough, I have been using fine on any compiler. |
Contributor
Author
|
Great. I'm going to merge this patchset then. Would you mind doing the same investigation for single precision float? |
Closed
Contributor
|
Thanks for merging this! Sure, I will have a look next week when I have a moment. Would you mind considering the API I was suggesting for reducing interleaved complex? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's generally slower than the sse2 version due to a latency of 5 (!) for hadd_pd.
Related to #1107